Skip to content

fix(overlay): prevent detached DOM nodes during React inline overlay dismiss #30344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix(overlay): prevent detached DOM nodes during React inline overlay dismiss #30344

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/react/src/components/createInlineOverlayComponent.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,8 +199,10 @@ export const createInlineOverlayComponent = <PropType, ElementType>(
* that removes the item.)
*/
if (wrapper && el) {
// The delegate's removeViewFromDom call handles unmounting the React component.
// Setting state here can cause race conditions.
// Restore the wrapper to the element before the delegate removes it.
el.append(wrapper);
this.setState({ isOpen: false });
}

this.props.onDidDismiss && this.props.onDidDismiss(evt);
Expand Down
Loading