Skip to content

fix(progress-bar, spinner): update colors for ionic theme #30418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 23, 2025
Merged

fix(progress-bar, spinner): update colors for ionic theme #30418

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ea599ff
- Fix Progress-Bar Ionic Colors;
JoaoFerreira-FrontEnd May 21, 2025
fcc3e84
Merge branch 'next' into ROU-11917
JoaoFerreira-FrontEnd May 21, 2025
a00cc6f
- clean selector;
JoaoFerreira-FrontEnd May 23, 2025
6683f18
- lint.fix
JoaoFerreira-FrontEnd May 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions core/src/components/progress-bar/progress-bar.common.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,13 +146,6 @@
}
}

:host(.ion-color) {
.progress,
.progress-indeterminate {
background: #{current-color(base)};
}
}

// Progress Bar: Animation Keyframes
// ------------------------------------------------------------------------
// Source: https://github.com/material-components/material-components-web/blob/master/packages/mdc-linear-progress/_keyframes.scss
Expand Down
7 changes: 7 additions & 0 deletions core/src/components/progress-bar/progress-bar.ionic.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,13 @@
// Progress Bar: Color
// ------------------------------------------------------------------------

:host(.ion-color) {
.progress,
.progress-indeterminate {
background: #{globals.current-color(base)};
}
}

:host(.ion-color) .buffer-circles {
background-image: radial-gradient(
ellipse at center,
Expand Down
7 changes: 7 additions & 0 deletions core/src/components/progress-bar/progress-bar.native.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,13 @@
// Progress Bar: Color
// ------------------------------------------------------------------------

:host(.ion-color) {
.progress,
.progress-indeterminate {
background: #{current-color(base)};
}
}

:host(.ion-color) .buffer-circles {
background-image: radial-gradient(
ellipse at center,
Expand Down
4 changes: 4 additions & 0 deletions core/src/components/spinner/spinner.ionic.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,10 @@
height: globals.$ion-scale-700;
}

:host(.ion-color.ion-color-medium) {
color: globals.current-color(contrast, null, true);
}

// Spinner: lines / lines-small / lines-sharp / lines-sharp-small
// --------------------------------------------------

Expand Down
Loading