Skip to content

Comments

CAPI 1.9, k8s/* 0.31, controller-runtime 0.19, controller-tools 0.16.5#388

Merged
wikkyk merged 19 commits intomainfrom
capi-1.9
Mar 12, 2025
Merged

CAPI 1.9, k8s/* 0.31, controller-runtime 0.19, controller-tools 0.16.5#388
wikkyk merged 19 commits intomainfrom
capi-1.9

Conversation

@wikkyk
Copy link
Collaborator

@wikkyk wikkyk commented Jan 27, 2025

Issue #, if available:
closes #361 #380 #385 #387 #424

Description of changes:
Updates:

  • sigs.k8s.io/cluster-api* to 1.9.5
  • k8s.io/* to 0.31.6
  • sigs.k8s.io/controller-runtime to 0.19.6
  • controller-gen to 0.16.5 (the last version for k8s 0.31)
  • deps

CRDs and RBAC regenerated with new controller-gen against new APIs.

e2e config updated for CAPI 1.9.5 and k8s 1.31.6.

Testing performed:
the usual

@github-actions
Copy link

🚀 e2e tests run

We add labels to the PRs to control the e2e test runs by running specific tests and skipping some test contexts,
please follow this guide:

Label Behaviour
none Run Generic tests
e2e/none skip all e2e tests (documentation etc) - overrides all e2e/* labels Do not run any tests (overrides all e2e/ flags)
e2e/flatcar run Flatcar e2e tests Add Flatcar tests to the run

ℹ️ Ask a Member to add the requested labels if you don't have enough permissions.

@github-actions
Copy link

External PR

Test runs on external PRs require manual approval.

Note: This PR changes the following non-go, non-docs files:
config/crd/bases/infrastructure.cluster.x-k8s.io_proxmoxclusters.yaml
config/crd/bases/infrastructure.cluster.x-k8s.io_proxmoxclustertemplates.yaml
config/crd/bases/infrastructure.cluster.x-k8s.io_proxmoxmachines.yaml
config/crd/bases/infrastructure.cluster.x-k8s.io_proxmoxmachinetemplates.yaml
config/rbac/role.yaml

@github-actions
Copy link

External PR

Test runs on external PRs require manual approval.

Note: This PR changes the following non-go, non-docs files:
go.mod
go.sum

@github-actions
Copy link

External PR

Test runs on external PRs require manual approval.

Note: This PR changes the following non-go, non-docs files:
test/e2e/config/proxmox-ci.yaml

@github-actions
Copy link

External PR

Test runs on external PRs require manual approval.

@wikkyk
Copy link
Collaborator Author

wikkyk commented Jan 29, 2025

@github-actions
Copy link

github-actions bot commented Feb 6, 2025

External PR

Test runs on external PRs require manual approval.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 6, 2025

@wikkyk
Copy link
Collaborator Author

wikkyk commented Mar 12, 2025

Failed conditions 60.0% Coverage on New Code (required ≥ 80%)

This is a spurious failure, there is no new code here per se.

Copy link
Member

@mcbenjemaa mcbenjemaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wikkyk wikkyk merged commit de65752 into main Mar 12, 2025
8 of 10 checks passed
@wikkyk wikkyk deleted the capi-1.9 branch March 12, 2025 14:40
@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
60.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

e2e/flatcar run Flatcar e2e tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants