Simplify the grammar of the ROS model DSL #122
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simplifies the grammar to describe a ROS package and a node.
For example, the ros driver for the sick s300 scanner using the old version of the ros model looks:
With the changes proposed here, the same node can be defined as:
The proposed version of the
de.fraunhofer.ipa.ros.xtextis backward compatible, i.e. support also models created following the old version of the grammar. The parts of the code to be deleted, in a future, to support only the new grammar are marked with the comment "to be deprecated"