fix: add /routing/v1 example to ipni.md #1931
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubo, rainbow and helia all use /routing/v1, yet the document has a prominent example that hits /cid this lead to more than one outage where only /cid was checked, but /routing/v1 did not work correctly this adds a prominent example how /routing/v1 is used and whi, links to relevant specs, and adds some useful references, as a bare minimum to adjust perspective how IPFS uses IPNI
lidel
changed the title
2color
reviewed
Sep 30, 2024
gammazero
approved these changes
Sep 30, 2024
2color
reviewed
Oct 1, 2024
2color
reviewed
Oct 1, 2024
Co-authored-by: Daniel Norman <[email protected]> Co-authored-by: Andrew Gillis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kubo, rainbow and helia all use
/routing/v1, yetthe
ipni.mddocument has a prominent example that hits/cidhistorically, focus on
/cidlead to more than one outage where only/cidwas checked, but/routing/v1did not work correctlythis PR adds a prominent example how
/routing/v1is used and why it exists, links to relevant specs, and adds some useful references, as a bare minimum to adjust perspective how IPFS uses IPNI in real world