Bring back TXCREATE + simpler EOFCREATE address scheme + make address calculation ASE-ready #177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shemnon
reviewed
Jan 27, 2025
gumb0
reviewed
Jan 28, 2025
This was referenced Jan 28, 2025
shemnon
reviewed
Jan 30, 2025
This was referenced Jan 31, 2025
gumb0
reviewed
Feb 4, 2025
gumb0
force-pushed
the
re-tx-create
branch
3 times, most recently
from
cb2ec20 to
2f1d923
Compare
frangio
reviewed
Feb 19, 2025
gumb0
reviewed
Feb 20, 2025
pdobacz
force-pushed
the
re-tx-create
branch
from
be92d5a to
93c9757
Compare
gumb0
approved these changes
Feb 20, 2025
frangio
reviewed
Mar 5, 2025
The cost of validation is covered by transaction's initcode cost (part of intrinsic cost.)
Co-authored-by: Francisco Giordano <[email protected]>
Member
Author
Member
Author
|
NOTE, that following ethereum/EIPs#9561 I've pushed a change to make INITCODE_TX_TYPE be 0x06: fb0d6b8 |
Member
Author
|
NOTE, that following ethereum/EIPs#9593 I've pushed a change to unban TXCREATE in legacy and ditch the creator contract |
gumb0
approved these changes
Apr 7, 2025
gumb0
changed the title
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in EOF Implementers Call 65 it seems like there is much more argumentation backing the previous design, which utilized TXCREATE and a new InitcodeTransaction type. This has become evident once more feedback from app-layer developers surfaced.
The new EIP (in exchange for EIP-7698) is yet to be written, with the expanded rationale, for now we only dip the toe in the water by reverting (with suitable refresher changes) the change which removed TXCREATE and introduced EOF creation txs.
This PR is divided into commits, starting from "raw" revert, then followed by extra updates on top.
One of these updates which isn't only a "refresher change" is the removal of
initcode_hashfrom the hashing scheme, following discussions in this issue, as summarized in the so-called "Scenario 1b" from this notes document outlining our options