Sort lists in cmake files in pre-commit#1084
Conversation
kuhar
left a comment
kuhar
left a comment
There was a problem hiding this comment.
Can you land the cleanup separately from the pre-commit hook?
|
I can but whats the point? (Also it's wave repo, I haven't tried on iree or llvm yet) |
Easier to revert if the hook goes rouge.
🤦 I missed this part |
| # Sort file and library lists in CMake files. | ||
| - repo: https://github.com/Hardcode84/3 | ||
| rev: v0.1.0 | ||
| hooks: | ||
| - id: sort-cmake-lists | ||
| exclude: llvm-project/ |
There was a problem hiding this comment.
Can we have this script live locally under .pre-commit instead?
repos:
- repo: local
hooks:
- id: sort-cmake-lists
name: Sort CMake lists
entry: .pre-commit/sort-cmake-lists.py
language: python
exclude: llvm-project/There was a problem hiding this comment.
I will think about it and I'm not in particular haste, lets merge the cmake changes then
There was a problem hiding this comment.
Now, I think I'll keep it as a external dep, as I'm planning to use it in multiple projects.
ftynse
left a comment
ftynse
left a comment
There was a problem hiding this comment.
LGTM. Looks like useful hook elsewhere, but perhaps with a better repo name.
Automated sort via sort-cmake-lists pre-commit hook from #1084 Signed-off-by: Ivan Butygin <ivan.butygin@gmail.com> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Hardcode84
force-pushed
the
cmake-pre-commit
branch
from
3656800 to
3363613
Compare
|
repo name is perfect, I have no intention to change it |
Hardcode84
force-pushed
the
cmake-pre-commit
branch
2 times, most recently
from
e214fe2 to
0dd26dc
Compare
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Ivan Butygin <ivan.butygin@gmail.com>
Hardcode84
force-pushed
the
cmake-pre-commit
branch
from
0dd26dc to
cf64554
Compare
4 participants
They were hurting my aesthetic feelings for way too long.