Skip to content

Sort lists in cmake files in pre-commit #1084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Hardcode84 merged 2 commits into from
Mar 21, 2026
Merged

Sort lists in cmake files in pre-commit #1084

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a718557
Add sort-cmake-lists pre-commit hook
Hardcode84 Mar 9, 2026
cf64554
sort
Hardcode84 Mar 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,3 +31,10 @@ repos:
- id: clang-format
name: Run clang-format on C/C++/etc. files
exclude_types: ["jupyter", "json"]

# Sort file and library lists in CMake files.
- repo: https://github.com/Hardcode84/3
rev: v0.3.0
hooks:
- id: sort-cmake-lists
exclude: llvm-project/
Comment on lines +35 to +40
Copy link
Contributor

@tgymnich tgymnich Mar 9, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have this script live locally under .pre-commit instead?

repos:
  - repo: local
    hooks:
      - id: sort-cmake-lists
        name: Sort CMake lists
        entry: .pre-commit/sort-cmake-lists.py
        language: python
        exclude: llvm-project/

Copy link
Contributor Author

@Hardcode84 Hardcode84 Mar 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will think about it and I'm not in particular haste, lets merge the cmake changes then

Copy link
Contributor Author

@Hardcode84 Hardcode84 Mar 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now, I think I'll keep it as a external dep, as I'm planning to use it in multiple projects.

4 changes: 2 additions & 2 deletions water/lib/Pipelines/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,9 @@ add_mlir_library(MLIRWaterPipelines

LINK_LIBS PUBLIC
MLIRIR
MLIRPass
MLIRTransforms
MLIRNormalFormDialect
MLIRNormalFormTransforms
MLIRPass
MLIRTransforms
MLIRWaveTransforms
)
2 changes: 1 addition & 1 deletion water/tools/water-opt/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@ set(LIBS
MLIRArithDialect
MLIRGPUDialect
MLIRGPUToLLVMIRTranslation
MLIRLLVMToLLVMIRTranslation
MLIRLinalgTransformOps
MLIRLLVMToLLVMIRTranslation
MLIRMemRefTransformOps
MLIRNormalFormDialect
MLIRNormalFormTransforms
Expand Down
2 changes: 1 addition & 1 deletion waveasm/tools/waveasm-translate/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,10 @@ target_link_libraries(waveasm-translate
MLIRGPUDialect
MLIRIR
MLIRLLVMDialect
MLIRROCDLDialect
MLIRMemRefDialect
MLIRParser
MLIRPass
MLIRROCDLDialect
MLIRSCFDialect
MLIRSupport
MLIRTransforms
Expand Down
Loading