get XMLHttpRequest at call time (aka sinon support) #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
April 29, 2014 13:28
so that we can replace if we want to, such as when mocking
It should be up to the caller to decide if a non-JSON body is actually an error state. For example: you make a request where you expect a JSON response, but instead you get 204 No Content. It should be up to your application to decide what that means.
|
Heh, I just opened a PR for fixing basically the same thing. I won't hold my breath to see either one of them merged. |
|
+1 - Ive done the same fix - should have checked here first !! Lesson learned. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allows XMLHttpRequest to become a new reference, such as a mock sinon object, and for that new reference to be used by this module