Skip to content

get XMLHttpRequest at call time (aka sinon support) #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

get XMLHttpRequest at call time (aka sinon support) #27

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e39e2d8
get XMLHttpRequest at call time
Apr 29, 2014
64f40de
Don’t error on JSON parse error
May 14, 2014
0ff037f
Merge branch 'json'
May 14, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,13 @@
// See the License for the specific language governing permissions and
// limitations under the License.

var XHR = XMLHttpRequest
if (!XHR) throw new Error('missing XMLHttpRequest')
var GetXHR = function(){
if(!XMLHttpRequest){
throw new Error('missing XMLHttpRequest');
}
return XMLHttpRequest;
}

request.log = {
'trace': noop, 'debug': noop, 'info': noop, 'warn': noop, 'error': noop
}
Expand Down Expand Up @@ -164,7 +169,8 @@ function request(options, callback) {

var req_seq = 0
function run_xhr(options) {
var xhr = new XHR
var XHR = GetXHR();
var xhr = new XHR()
, timed_out = false
, is_cors = is_crossDomain(options.uri)
, supports_cors = ('withCredentials' in xhr)
Expand Down Expand Up @@ -271,7 +277,7 @@ function run_xhr(options) {
xhr.body = xhr.responseText
if(options.json) {
try { xhr.body = JSON.parse(xhr.responseText) }
catch (er) { return options.callback(er, xhr) }
catch (e) { }
}

options.callback(null, xhr, xhr.body)
Expand Down