prepare script improvements #710
Conversation
guvenc
force-pushed
the
feature/prepare_script_bf
branch
from
6c21460 to
c60181c
Compare
|
I notice that this PR contains the changes regarding the underlay prefix, would #709 cover it? and if it gets merged, would it be an issue to merge that one? |
Signed-off-by: Guvenc Gulce <[email protected]>
Signed-off-by: Guvenc Gulce <[email protected]>
Signed-off-by: Guvenc Gulce <[email protected]>
guvenc
force-pushed
the
feature/prepare_script_bf
branch
from
c60181c to
d36786c
Compare
|
@byteocean |
PlagueCZ
left a comment
PlagueCZ
left a comment
There was a problem hiding this comment.
Hard for me to test give then state of my work and the fact that we use ignition mostly, but it looks OK from what it's doing.
| modified_pci=${pf0::-3} | ||
|
|
||
| # pci address of vfs are organized in a block of 8 | ||
| # e.g., 3b:00.0 ... 3b:00.7, 3b:01.0 ... 3b:01.7, etc. |
There was a problem hiding this comment.
This comment was here to explain the strange for loop, because for those that do not know the VF numbering scheme it makes no sense just by reading the loop.
There was a problem hiding this comment.
Makes totally sense. I will add all the removed original comments.
hack/prepare.sh
Outdated
| fi | ||
| create_vf | ||
| make_config | ||
| make_config |
There was a problem hiding this comment.
Please do not remove endlines, when I sometimes cat files it messes up my terminal prompt :)
Signed-off-by: Guvenc Gulce <[email protected]>
guvenc
force-pushed
the
feature/prepare_script_bf
branch
from
b810bb8 to
b38a41a
Compare
PlagueCZ
left a comment
PlagueCZ
left a comment
There was a problem hiding this comment.
Changes make sense, cannot test in OSC as we use ignition for this part.
prepare script improvements