Skip to content

Modify volumebroker to filter volumes before aggregation #1407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lukasfrank merged 3 commits into from
Dec 11, 2025
Merged

Modify volumebroker to filter volumes before aggregation #1407

lukasfrank merged 3 commits into from
Dec 11, 2025

Conversation

@kasabe28
Copy link
Contributor

@kasabe28 kasabe28 commented Nov 10, 2025 •
edited
Loading

Proposed Changes

  • Modify volumebroker to filter volumes before aggregation and to add volumepoollet.ironcore.dev/volume-uid label with parent volume uid as value in CreateVolume function
  • Modify volumepoollet to list and delete volumes using volumepoollet.ironcore.dev/volume-uid label
  • Set volume uid label to all existing brokered volumes on startup as part up migration to avoid volume recreation.

Fixes #1405

@kasabe28 kasabe28 self-assigned this Nov 10, 2025
@kasabe28 kasabe28 requested a review from a team as a code owner November 10, 2025 08:43
@kasabe28 kasabe28 added this to IaaS and Roadmap Nov 10, 2025
@github-actions github-actions bot added enhancement New feature or request size/L labels Nov 10, 2025
@hardikdr hardikdr added the area/iaas Issues related to IronCore IaaS development. label Nov 11, 2025
@kasabe28 kasabe28 requested a review from balpert89 November 12, 2025 08:39
@balpert89
Copy link
Contributor

balpert89 commented Nov 12, 2025

LGTM

@opensovereigncloud-user opensovereigncloud-user force-pushed the osc/enh/update-volume-filtering branch from f8dbd4e to dff98fb Compare November 14, 2025 11:36
lukasfrank
lukasfrank requested changes Nov 26, 2025
View reviewed changes
Copy link
Member

@lukasfrank lukasfrank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the proposed change work for existing Volumes . It looks like we recreate a Volume if the label is not present

@opensovereigncloud-user opensovereigncloud-user force-pushed the osc/enh/update-volume-filtering branch from dff98fb to c0171ff Compare December 1, 2025 09:03
@github-actions github-actions bot added size/M and removed size/L labels Dec 1, 2025
@lukasfrank
Copy link
Member

lukasfrank commented Dec 1, 2025

Does the proposed change work for existing Volumes . It looks like we recreate a Volume if the label is not present

As offline discussed: Check if it is possible to use the volumebroker.ironcore.dev/labels annotation to run migration on startup of broker.

@github-actions github-actions bot added size/L and removed size/M labels Dec 3, 2025
@opensovereigncloud-user opensovereigncloud-user force-pushed the osc/enh/update-volume-filtering branch from 105e04c to 7afa384 Compare December 4, 2025 08:05
@opensovereigncloud-user opensovereigncloud-user force-pushed the osc/enh/update-volume-filtering branch from 7afa384 to 10f4076 Compare December 5, 2025 06:43
@opensovereigncloud-user opensovereigncloud-user force-pushed the osc/enh/update-volume-filtering branch from 10f4076 to 56e5d1f Compare December 8, 2025 09:23
@kasabe28 kasabe28 requested a review from afritzler December 8, 2025 09:23
balpert89
balpert89 approved these changes Dec 8, 2025
View reviewed changes
Copy link
Contributor

@balpert89 balpert89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@opensovereigncloud-user opensovereigncloud-user force-pushed the osc/enh/update-volume-filtering branch from 56e5d1f to e3f4314 Compare December 9, 2025 11:56
lukasfrank
lukasfrank requested changes Dec 10, 2025
View reviewed changes
@kasabe28 kasabe28 requested a review from lukasfrank December 11, 2025 07:09
lukasfrank
lukasfrank approved these changes Dec 11, 2025
View reviewed changes
Copy link
Member

@lukasfrank lukasfrank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@opensovereigncloud-user opensovereigncloud-user force-pushed the osc/enh/update-volume-filtering branch from ea88e20 to e67065d Compare December 11, 2025 08:39
@lukasfrank lukasfrank merged commit 894396b into ironcore-dev:main Dec 11, 2025
9 checks passed
@github-project-automation github-project-automation bot moved this to ✅ Done in IaaS Dec 11, 2025
@github-project-automation github-project-automation bot moved this to Done in Roadmap Dec 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lukasfrank lukasfrank lukasfrank approved these changes

@balpert89 balpert89 balpert89 approved these changes

@Rohit-0505 Rohit-0505 Rohit-0505 approved these changes

@afritzler afritzler Awaiting requested review from afritzler

Assignees

@kasabe28 kasabe28

Labels

area/iaas Issues related to IronCore IaaS development. enhancement New feature or request size/L

Projects

IaaS
Status: ✅ Done
Roadmap
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Listing volumes in the volumebroker should apply filtering first before processing

6 participants

@kasabe28 @balpert89 @lukasfrank @afritzler @Rohit-0505 @hardikdr