-
Notifications
You must be signed in to change notification settings - Fork 2.9k
[WIP] Unify Isaac Lab assets with Isaac Sim #4301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- Update test_utils_queries.py to use ISAAC_NUCLEUS_DIR with correct paths - Fix G1 Inspire Hand path to use ISAAC_NUCLEUS_DIR/Robots/Unitree/G1_29dof/ - Remove unused stage_utils imports from test files - Ensure consistent path naming (ANYmal-C -> anymal_c, etc.)
Greptile SummaryMigrated Isaac Lab asset paths from Key Changes:
Asset Path Pattern:
The migration is systematic and comprehensive, touching all robot assets, examples, and tests. Confidence Score: 4/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant User as User Code
participant Config as Robot Config
participant Assets as isaaclab.utils.assets
participant Spawner as sim_utils.UsdFileCfg
participant NucleusServer as Nucleus Server
participant Stage as USD Stage
User->>Config: Import robot configuration
Config->>Assets: Use ISAAC_NUCLEUS_DIR constant
Note over Assets: ISAAC_NUCLEUS_DIR = carb.settings<br/>/persistent/isaac/asset_root/cloud/Isaac
Config->>Config: Build asset path<br/>(e.g., {ISAAC_NUCLEUS_DIR}/Robots/FrankaRobotics/FrankaEmika/panda.usd)
User->>Spawner: Create UsdFileCfg with usd_path
Spawner->>Assets: check_file_path(usd_path)
Assets->>NucleusServer: omni.client.stat(usd_path)
NucleusServer-->>Assets: Return file status
Assets-->>Spawner: File exists on Nucleus
Spawner->>NucleusServer: Load USD from remote path
NucleusServer-->>Spawner: USD file data
Spawner->>Stage: Spawn prim at prim_path
Stage-->>User: Robot instantiated
|
Greptile's behavior is changing!From now on, if a review finishes with no comments, we will not post an additional "statistics" comment to confirm that our review found nothing to comment on. However, you can confirm that we reviewed your changes in the status check section. This feature can be toggled off in your Code Review Settings by deselecting "Create a status check for each PR". |
|
what is the status with the combination of the assets? |
Description
Rebasing and testing out Steven Feng's unify assets change - #3608
Type of change
Screenshots
Please attach before and after screenshots of the change if applicable.
Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there