Skip to content

Fix: broken links when regenerating archive docs #16747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 25, 2025
Merged

Fix: broken links when regenerating archive docs #16747

merged 1 commit into from
Aug 25, 2025

Conversation

Ajay-singh1
Copy link
Member

Description

Continuation of PR #16685

Reviewers

  • Ambient
  • Docs
  • Installation
  • Networking
  • Performance and Scalability
  • Extensions and Telemetry
  • Security
  • Test and Release
  • User Experience
  • Developer Infrastructure
  • Localization/Translation

@Ajay-singh1
Fix broken links
72166af 
Signed-off-by: Ajay Singh <[email protected]>
@Ajay-singh1 Ajay-singh1 requested a review from a team as a code owner August 4, 2025 06:51
@istio-testing istio-testing added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 4, 2025
@yuluo-yx
Copy link
Member

yuluo-yx commented Aug 6, 2025

/ok-to-test

@istio-testing istio-testing added the ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. label Aug 6, 2025
@Ajay-singh1 Ajay-singh1 added cherrypick/release-1.23 Set this label on a PR to auto-merge it to the release-1.23 branch cherrypick/release-1.24 Set this label on a PR to auto-merge it to the release-1.24 branch cherrypick/release-1.25 Set this label on a PR to auto-merge it to the release-1.25 branch cherrypick/release-1.26 Set this label on a PR to auto-merge it to the release-1.26 branch cherrypick/release-1.27 Set this label on a PR to auto-merge it to the release-1.27 branch labels Aug 21, 2025
@Ajay-singh1 Ajay-singh1 requested a review from craigbox August 21, 2025 11:33
@Ajay-singh1
Copy link
Member Author

@craigbox This has to go in to their respective release branches.

@Ajay-singh1
Copy link
Member Author

VID-20250730-WA0000.mp4

Local Testing.

@istio-testing istio-testing merged commit 36c5e1d into istio:master Aug 25, 2025
6 checks passed
@istio-testing
Copy link
Contributor

In response to a cherrypick label: #16747 failed to apply on top of branch "release-1.23":

Applying: Fix broken links
Using index info to reconstruct a base tree...
M	layouts/_default/baseof.html
Falling back to patching base and 3-way merge...
Auto-merging layouts/_default/baseof.html
CONFLICT (content): Merge conflict in layouts/_default/baseof.html
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 Fix broken links

@istio-testing
Copy link
Contributor

In response to a cherrypick label: new issue created for failed cherrypick: #16810

@istio-testing istio-testing mentioned this pull request Aug 25, 2025
Closed
@istio-testing
Copy link
Contributor

In response to a cherrypick label: new pull request created: #16811

@istio-testing istio-testing mentioned this pull request Aug 25, 2025
Closed
@istio-testing
Copy link
Contributor

In response to a cherrypick label: new pull request created: #16812

@istio-testing istio-testing mentioned this pull request Aug 25, 2025
Closed
@istio-testing
Copy link
Contributor

In response to a cherrypick label: new pull request created: #16813

@istio-testing istio-testing mentioned this pull request Aug 25, 2025
Merged
@istio-testing
Copy link
Contributor

In response to a cherrypick label: new pull request created: #16814

@istio-testing istio-testing mentioned this pull request Aug 25, 2025
Closed
@Ajay-singh1 Ajay-singh1 deleted the squash-the-bug branch August 25, 2025 10:46
@Ajay-singh1 Ajay-singh1 mentioned this pull request Aug 28, 2025
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@craigbox craigbox craigbox approved these changes

Assignees
No one assigned
Labels
cherrypick/release-1.23 Set this label on a PR to auto-merge it to the release-1.23 branch cherrypick/release-1.24 Set this label on a PR to auto-merge it to the release-1.24 branch cherrypick/release-1.25 Set this label on a PR to auto-merge it to the release-1.25 branch cherrypick/release-1.26 Set this label on a PR to auto-merge it to the release-1.26 branch cherrypick/release-1.27 Set this label on a PR to auto-merge it to the release-1.27 branch ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Ajay-singh1 @yuluo-yx @istio-testing @craigbox