-
Notifications
You must be signed in to change notification settings - Fork 7
Switch to enable/disable test execution for Testcontainers tests #1314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Switch to enable/disable test execution for Testcontainers tests #1314
Conversation
WalkthroughAdded the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@ejcsid I suggest annotating the Testcontainers tests with @EnabledIfDockerAvailable That way the tests are only executed if there is a Docker (or compatible daemon, eg. Podman) available on the machine executing the test. |
|
@eidottermihi is there a reason you prefer that? I would rather prefer the current change, as then the deactivation of the tests is an aktive decision and can not happen by accident. E.g. I often run the tests locally and just realize that docker isn't running when the tests fail. |
|
Alternatively instead of introducing a custom system property the @Tag-mechanism of JUnit can be used as well to disable certain tests. |
|
@simonhir ofc, if you want an active deciscion by the developer, than |
Pull Request
Changes
Reference
Issue: #1313
Checklist
Note: If some checklist items are not relevant for your PR, just remove them.
General
I have read the Contribution Guidelines (TBD)Code
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.