-
Notifications
You must be signed in to change notification settings - Fork 93
Update iRODS documentation to align with irods4j refactor #632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
24bd6a8 to
d64597c
Compare
|
Will squash to one commit once approved. |
|
Given the questions on the profile PR, I'm starting to think we need to add a note about the profile requiring the user to update it before use. Thoughts? |
It should definitely be documented which properties are required to be customized and we will not be able to publish a profile requiring customization through Preferences → Profiles. |
|
If requiring customization of the profile is a blocker, that suggests the user has to write the profile themselves - i.e. the documentation needs to list the required properties and also provide a skeleton profile for readers to copy. Is that correct? Is there an alternative? |
|
@dkocher Any thoughts on my previous comment? |
That is correct. We will not be able to distribute the profiles for selection in the user interface. The alternative is to prompt the user for input on missing configuration options. We do this for example for profiles using OAuth when the Client ID or Client Secret is missing 1. Footnotes |
|
Okay. I'm going to update the documentation to show the full profile for copy-paste purposes. Are Cyberduck users familiar with how to add a profile to their profile directory? |
|
Added section which shows the connection profile template in full (i.e. copied from iterate-ch/profiles#163). Adjusted wording too. |
|
@korydraughn Can you please fix the spelling error reported. |
|
Fixed spelling error reported by GHAs. Awaiting feedback and signal to squash commits so that this can move forward. |
|
@dkocher I fixed the reported spelling error. I think everything is ready now. Just need to see the GitHub Actions pass. Once those pass, I'll squash the commits so the history is clean. |
451f7e0 to
d333aed
Compare
|
Squashed commits down to one. All review comments have been addressed. I think this is ready. |

Uh oh!
There was an error while loading. Please reload this page.