Skip to content

Conversation

@korydraughn
Copy link

@korydraughn korydraughn commented Dec 9, 2025

@korydraughn
Copy link
Author

Will squash to one commit once approved.

@korydraughn
Copy link
Author

Given the questions on the profile PR, I'm starting to think we need to add a note about the profile requiring the user to update it before use.

Thoughts?

@dkocher
Copy link
Contributor

dkocher commented Dec 15, 2025

Given the questions on the profile PR, I'm starting to think we need to add a note about the profile requiring the user to update it before use.

Thoughts?

It should definitely be documented which properties are required to be customized and we will not be able to publish a profile requiring customization through Preferences → Profiles.

@dkocher dkocher self-requested a review December 15, 2025 08:58
@korydraughn
Copy link
Author

If requiring customization of the profile is a blocker, that suggests the user has to write the profile themselves - i.e. the documentation needs to list the required properties and also provide a skeleton profile for readers to copy.

Is that correct? Is there an alternative?

@korydraughn
Copy link
Author

@dkocher Any thoughts on my previous comment?

@dkocher
Copy link
Contributor

dkocher commented Jan 19, 2026

If requiring customization of the profile is a blocker, that suggests the user has to write the profile themselves - i.e. the documentation needs to list the required properties and also provide a skeleton profile for readers to copy.

Is that correct? Is there an alternative?

That is correct. We will not be able to distribute the profiles for selection in the user interface. The alternative is to prompt the user for input on missing configuration options. We do this for example for profiles using OAuth when the Client ID or Client Secret is missing 1.

Footnotes

  1. https://github.com/iterate-ch/cyberduck/blob/78e0b63d15908f05508062cb24ba536809647a3d/oauth/src/main/java/ch/cyberduck/core/oauth/OAuth2AuthorizationService.java#L419-L435

@korydraughn
Copy link
Author

Okay. I'm going to update the documentation to show the full profile for copy-paste purposes.

Are Cyberduck users familiar with how to add a profile to their profile directory?
Is that documented somewhere? I'd like to link to that page/section to avoid duplication.

@korydraughn
Copy link
Author

Added section which shows the connection profile template in full (i.e. copied from iterate-ch/profiles#163).

Adjusted wording too.

@dkocher
Copy link
Contributor

dkocher commented Jan 21, 2026

@korydraughn Can you please fix the spelling error reported.

@korydraughn
Copy link
Author

Fixed spelling error reported by GHAs.

Awaiting feedback and signal to squash commits so that this can move forward.

@korydraughn
Copy link
Author

korydraughn commented Jan 26, 2026

@dkocher I fixed the reported spelling error.

I think everything is ready now. Just need to see the GitHub Actions pass.

Once those pass, I'll squash the commits so the history is clean.

@korydraughn
Copy link
Author

Here's a screenshot of the rendered documentation.

image

@korydraughn
Copy link
Author

Squashed commits down to one.

All review comments have been addressed.

I think this is ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants