Additional error handling and testing#17
Merged
SBlokhuizen merged 26 commits intodevelopfrom Feb 14, 2025
Merged
Conversation
maarten-ic
reviewed
Feb 13, 2025
| prev_tendency: The tendency precedes the current tendency. | ||
| """ | ||
| self.prev_tendency = prev_tendency | ||
| # If the tendency is the first tendency of a repeated tendency, it is linked to |
Collaborator
There was a problem hiding this comment.
Hmm, by doing this only during set_previous_tendency, we lose the declarative nature of updating the user_ parameters and let everything update itself (without re-instantiating all objects).
Though this is the case for all error handling (because any issue is just added to the existing annotations)...
Let's discuss? It works now, but the mix of some declarative logic (e.g. _calc_times) mixed with imperative logic (e.g. this method) could be confusing
…atch call watchers when setting params
maarten-ic
reviewed
Feb 14, 2025
e9d1ae6 to
0f4b788
Compare
maarten-ic
reviewed
Feb 14, 2025
maarten-ic
approved these changes
Feb 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
waveform.pyandannotations.pyare introduced.read_yaml_from_filemethod is updated to also use annotations.