Update Electron to latest: update webpack to vite by Andrii727 · Pull Request #128 · ituob/itu-ob-editor

Andrii727 · 2024-11-29T12:46:01Z

update the electron to latest and migrate from webpack to vite.

ronaldtse · 2024-11-29T13:12:10Z

FYI for @strogonoff . This PR is still a draft and not yet ready.

hound · 2024-12-04T14:38:11Z

main.webpack.js

+  config.optimization = {
+    ...config.optimization,
+    moduleIds: "named",
+  };


Unexpected '}'.

hound · 2024-12-04T14:38:11Z

main.webpack.js


+  config.optimization = {
+    ...config.optimization,
+    moduleIds: "named",


Expected '}' to match '{' from line 4 and instead saw ':'.
Expected an assignment or function call and instead saw an expression.
Missing semicolon.
Unrecoverable syntax error. (29% scanned).

hound · 2024-12-04T14:38:11Z

main.webpack.js

+  config.resolve.modules = [path.resolve(__dirname, "./src"), "node_modules"];

+  config.optimization = {
+    ...config.optimization,


Expected '}' to match '{' from line 7 and instead saw '...'.
Missing semicolon.

hound · 2024-12-04T14:38:11Z

main.webpack.js

-const path = require('path');
-const ThreadsPlugin = require('threads-plugin');
+const path = require("path");
+const ThreadsPlugin = require("threads-plugin");


'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

hound · 2024-12-04T14:38:11Z

main.webpack.js

@@ -1,28 +1,30 @@
-const path = require('path');
-const ThreadsPlugin = require('threads-plugin');
+const path = require("path");


'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

strogonoff · 2024-12-09T11:34:09Z

@SmartWolf1220 Could you please list the steps needed to test & build the ITU OB Editor with your PRs, from clean slate, that you have tested?

Including any pre-requisites, such as Node version(s).

Note that I was able to run prepublish script on Coulomb lib, so that may be OK for now.

However, I am unable to run build the app itself (this repository).

Node v12 that you mentioned before will not work, because some dependencies that you updated in this PR now require Node v18. However, after switching to Node v18, while yarn install would work, the cdist script would fails with various TSC errors. Please verify.

cc @ronaldtse

Andrii727 · 2024-12-09T11:41:07Z

First, you can remove yarn.lock and node modules.
Second, you can use Node 18.19.0, and yarn install.
Third, use yarn run dev.

strogonoff · 2024-12-09T11:46:58Z

yarn run dev will not build the app, it only runs the app in dev mode. It will already be helpful and appreciated, but we must be able to build & package the app (which, e.g., the cdist script does) to deliver it to the end users.

strogonoff · 2024-12-09T11:47:31Z

you can remove yarn.lock

If Yarn’s lockfile is outdated, please update this PR with the new lockfile that contains the required versions of the packages. I’ll pull the new lockfile and try with those versions.

Andrii727 · 2024-12-09T11:51:31Z

Wait for a moment.
I am checking on my side.
I will let you know in several minutes.

Andrii727 · 2024-12-09T15:01:45Z

First, remove node_modules and yarn.lock.
Second, yarn install,
Third, yarn clean.
Last, yarn run dist:win, or dist:mac, or dist:linux.

ronaldtse · 2024-12-11T07:20:12Z

@SmartWolf1220 what’s going on? The build is still not ready? How come the build is still failing?

strogonoff · 2024-12-11T11:24:36Z

@ronaldtse Wait a moment, let me test the latest changes on this PR since my last comment… If it builds, it builds.

However, @SmartWolf1220 keep in mind that if the lockfile is outdated, it is expected that you will commit the up-to-date lockfile with exact package versions. Otherwise you’re leaving the exact versions of packages up to fate at build time, and that’s not great for reproducible builds.

Clearing a lockfile means allowing all packages to update, which is both a security liability and can lead to broken builds. So, please, don’t ask us to delete the lockfile. If you want, you can delete and regenerate it yourself, in which case please commit the updated lockfile version.

strogonoff · 2024-12-11T11:44:54Z

First, remove node_modules and yarn.lock. Second, yarn install, Third, yarn clean. Last, yarn run dist:win, or dist:mac, or dist:linux.

So far I am seeing this error after running dist:mac, copying the .app from the .dmg, and running it:

Uncaught Exception:
Error: [HMR] Env ELECTRON_HMR_SOCKET_PATH is not set at eval (webpack-internal:///./node_modules/electron-webpack/out/electron-
main-hmr/main-hmr.js: 8:9)```

strogonoff · 2024-12-11T11:45:44Z

@SmartWolf1220 Have you tested the steps you wrote? They may be missing the compile command… dist does not compile.

strogonoff · 2024-12-11T11:53:18Z

@SmartWolf1220 As of latest changes, after compiling the app with Coulomb version from your other PR, the .app can be launched, which is great. Removing lockfile was not necessary.

@ronaldtse I believe I got the app to successfully launch on arm64. I will re-check and merge the PR.

I guess next steps is we can see that it builds on GHA, including for Debian, and fix other blocking issues.

strogonoff · 2024-12-11T11:56:50Z

For me to merge this PR it needs to not have draft status, though.

strogonoff · 2024-12-11T12:03:30Z

I will need to go through all of the changes in this PR in order to make sure all is OK. There are a lot of stylistic changes (e.g., every single quote was changed to a double quote). Without them it would be much faster.

I don’t know whether a bunch of changes were made because of that “hound” linter. If so, it must be turned off, because we don’t want to have to review 99% stylistic changes in every PR. cc @ronaldtse

strogonoff · 2024-12-11T12:04:41Z

Apparently I can remove the draft status :)

strogonoff · 2024-12-11T12:06:08Z

On the main screen, I observe what looks like somewhat broken layout. Not yet sure whether it’s a regression after this PR…

Andrii727 · 2024-12-11T12:14:00Z

@strogonoff , I will check the layout.

Andrii727 · 2024-12-11T12:15:33Z

Anyway, is it working well on your side with node 18?

ronaldtse · 2024-12-11T12:22:20Z

How come the lint and tests jobs are both failing here?

Add Linux Build

Andrii727 · 2024-12-13T10:45:01Z

Hello @strogonoff , It works well on Linux Debian too.

…into upgrade-vite

Andrii727 · 2024-12-16T07:00:02Z

Hello @strogonoff , I think the test fails because of node version.

strogonoff · 2024-12-17T08:12:23Z

How come the lint and tests jobs are both failing here?

@ronaldtse I did not update other jobs, just the build jobs. The other jobs are not that critical right now. Probably they use a wrong Node version.

strogonoff · 2024-12-17T08:20:13Z

So, as of today, we have this:

New version of Coulomb was released under “dev” tag, from test-smartwolf-changes branch
- I will go through those changes and separate stylistic changes before merging into main branch and release NPM tag later
This PR on ITUOBE was updated to
- switch to Coulomb dev version in dependencies
- enable GHA build workflow for PR branches
- enable Ubuntu build in GHA build

Status of GHA build testing

On Ubuntu just now I got the confirmation the GHA build can launch and basically function
- Same on Debian
- I believe it’s successfully using gnome-keyring for password storage
On macOS it cannot launch with this error:
On Windows: to be tested

cc @ronaldtse @SmartWolf1220

strogonoff · 2024-12-17T08:22:37Z

@strogonoff once we merge this we can close a list of the automated Dependabot PRs.

We can close them at any point. I don’t see them as particularly helpful.

…grade-vite

hound · 2024-12-23T06:32:39Z

renderer.webpack.js

+    resolve: {
+      modules: [path.resolve(__dirname, "./src"), "node_modules"],
+      extensions: [".ts", ".tsx", ".js", ".jsx"],
+      alias: {


Expected an assignment or function call and instead saw an expression.
Missing semicolon.
Unrecoverable syntax error. (35% scanned).

hound · 2024-12-23T06:32:39Z

renderer.webpack.js

+    ...config,
+    resolve: {
+      modules: [path.resolve(__dirname, "./src"), "node_modules"],
+      extensions: [".ts", ".tsx", ".js", ".jsx"],


Expected '}' to match '{' from line 7 and instead saw ':'.
Expected an assignment or function call and instead saw an expression.
Missing semicolon.

hound · 2024-12-23T06:32:39Z

renderer.webpack.js

+  const newConfig = {
+    ...config,
+    resolve: {
+      modules: [path.resolve(__dirname, "./src"), "node_modules"],


Label 'modules' on [ statement.

hound · 2024-12-23T06:32:39Z

renderer.webpack.js

+  // Create a fresh config object
+  const newConfig = {
+    ...config,
+    resolve: {


Expected '}' to match '{' from line 3 and instead saw ':'.
Expected an assignment or function call and instead saw an expression.
Missing semicolon.

hound · 2024-12-23T06:32:40Z

renderer.webpack.js

+module.exports = function (config) {
+  // Create a fresh config object
+  const newConfig = {
+    ...config,


Expected '}' to match '{' from line 5 and instead saw '...'.
Missing semicolon.

hound · 2024-12-23T06:32:40Z