Remove redundant uv pip install step after uv sync #135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: jacksonpradolima <[email protected]>
|
Copilot
AI
changed the title
[WIP] Update code quality workflow enhancements based on feedback
Remove redundant uv pip install step after uv sync
Dec 28, 2025
jacksonpradolima
merged commit e791890
into
codex/update-github-actions-for-code-quality
29 of 34 checks passed
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes redundant uv pip install -e . commands that were unnecessarily executed after uv sync --frozen --extra dev in the CI workflow. The uv sync command already installs the project in editable mode based on the pyproject.toml configuration, making the subsequent pip install step unnecessary and potentially problematic.
- Removed duplicate installation step from the
code-qualityjob - Removed duplicate installation step from the
rust-backendjob
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The workflow runs
uv pip install -e .afteruv sync --frozen, which is redundant.uv syncalready installs the project in editable mode when configured inpyproject.toml.Changes
uv pip install -e .from bothcode-qualityandrust-backendjobs in.github/workflows/code_quality.ymluv sync --frozen --extra devfor dependency installationThis eliminates the redundant installation step that could potentially install into a different environment than the one created by
uv sync.✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.