Skip to content

chore(preprod): Slightly improve error UI for size upload failure case #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

chore(preprod): Slightly improve error UI for size upload failure case #49

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions static/app/views/preprod/buildDetails/buildDetails.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,8 +98,9 @@ export default function BuildDetails() {
<BuildError
title="Build details unavailable"
message={
buildDetailsQuery.error?.message ||
'Unable to load build details for this artifact' // TODO(preprod): translate once we have a final design
typeof buildDetailsQuery.error?.responseJSON?.error === 'string'
? buildDetailsQuery.error?.responseJSON.error
: 'Unable to load build details for this artifact' // TODO(preprod): translate once we have a final design
}
/>
</Layout.Page>
Expand Down