Add svg icons from Django 1.9 and use static function#218
Open
claudep wants to merge 1 commit intojazzband:masterfrom
Open
Add svg icons from Django 1.9 and use static function#218claudep wants to merge 1 commit intojazzband:masterfrom
claudep wants to merge 1 commit intojazzband:masterfrom
Conversation
Collaborator
|
Thanks! If wait and submit aren't there yet, perhaps we should not close the SVG ticket altogether. Any chance we could find equivalent SVG icons for these messages to fully finish this off? |
Collaborator
Author
|
It shouldn't too hard to convert waiting.gif to svg, but submitting.gif is animated, so it's trickier to convert (don't know the status of animated SVG in current browsers). |
|
@DoctorBob if you are willing to add a non-standard lib, then check out https://loading.io/spinner/ - It would enable you to add a animated svg Icon. |
Collaborator
|
@dkdndes Sounds like overkill to me. Couldn't we just use one of their spinners and copy it as a direct replacement? |
Collaborator
|
I guess the simplest option would be to add a static SVG spinner image and then use stepped CSS animation to animate it. |
716b4d8 to
e48481c
Compare
87e32e0 to
7071815
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #172.