Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 16 additions & 12 deletions newsletter/admin.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
from django.conf.urls import url

from django.contrib import admin, messages
from django.contrib.admin.templatetags.admin_static import static
from django.contrib.sites.models import Site

from django.core import serializers
Expand Down Expand Up @@ -46,15 +47,18 @@

from .settings import newsletter_settings

# Contsruct URL's for icons
ICON_URLS = {
'yes': '%snewsletter/admin/img/icon-yes.gif' % settings.STATIC_URL,
'wait': '%snewsletter/admin/img/waiting.gif' % settings.STATIC_URL,
'submit': '%snewsletter/admin/img/submitting.gif' % settings.STATIC_URL,
'no': '%snewsletter/admin/img/icon-no.gif' % settings.STATIC_URL
'yes': 'newsletter/admin/img/icon-yes.svg',
'wait': 'newsletter/admin/img/waiting.gif',
'submit': 'newsletter/admin/img/submitting.gif',
'no': 'newsletter/admin/img/icon-no.svg',
}


def icon_url(icon_name):
return static(ICON_URLS[icon_name])


class NewsletterAdmin(admin.ModelAdmin):
list_display = (
'title', 'admin_subscriptions', 'admin_messages', 'admin_submissions'
Expand Down Expand Up @@ -124,23 +128,23 @@ def admin_status(self, obj):
if obj.sent:
return format_html(
'<img src="{}" width="10" height="10" alt="{}"/>',
ICON_URLS['yes'], self.admin_status_text(obj)
icon_url('yes'), self.admin_status_text(obj)
)
else:
if obj.publish_date > now():
return format_html(
'<img src="{}" width="10" height="10" alt="{}"/>',
ICON_URLS['wait'], self.admin_status_text(obj)
icon_url('wait'), self.admin_status_text(obj)
)
else:
return format_html(
'<img src="{}" width="12" height="12" alt="{}"/>',
ICON_URLS['wait'], self.admin_status_text(obj)
icon_url('wait'), self.admin_status_text(obj)
)
else:
return format_html(
'<img src="{}" width="10" height="10" alt="{}"/>',
ICON_URLS['no'], self.admin_status_text(obj)
icon_url('no'), self.admin_status_text(obj)
)
admin_status.short_description = ''

Expand Down Expand Up @@ -367,12 +371,12 @@ def admin_status(self, obj):
img_tag = '<img src="{}" width="10" height="10" alt="{}"/>'
alt_txt = self.admin_status_text(obj)
if obj.unsubscribed:
return format_html(img_tag, ICON_URLS['no'], alt_txt)
return format_html(img_tag, icon_url('no'), alt_txt)

if obj.subscribed:
return format_html(img_tag, ICON_URLS['yes'], alt_txt)
return format_html(img_tag, icon_url('yes'), alt_txt)
else:
return format_html(img_tag, ICON_URLS['wait'], alt_txt)
return format_html(img_tag, icon_url('wait'), alt_txt)
admin_status.short_description = ''

def admin_status_text(self, obj):
Expand Down
Binary file removed newsletter/static/newsletter/admin/img/icon-no.gif
Binary file not shown.
3 changes: 3 additions & 0 deletions newsletter/static/newsletter/admin/img/icon-no.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file removed newsletter/static/newsletter/admin/img/icon-yes.gif
Binary file not shown.
3 changes: 3 additions & 0 deletions newsletter/static/newsletter/admin/img/icon-yes.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions tests/test_admin.py
Original file line number Diff line number Diff line change
Expand Up @@ -102,12 +102,12 @@ def test_subscription_admin(self):
response = self.client.get(changelist_url)
self.assertContains(
response,
'<img src="/static/newsletter/admin/img/icon-no.gif" width="10" height="10" alt="Unsubscribed"/>',
'<img src="/static/newsletter/admin/img/icon-no.svg" width="10" height="10" alt="Unsubscribed"/>',
html=True
)
self.assertContains(
response,
'<img src="/static/newsletter/admin/img/icon-yes.gif" width="10" height="10" alt="Subscribed"/>',
'<img src="/static/newsletter/admin/img/icon-yes.svg" width="10" height="10" alt="Subscribed"/>',
html=True
)
self.assertContains(
Expand Down