Revert "Revert "Revert "Hide most of non-public symbols by default (#984)" (#1038)""

[jbeder]

Reverts #1045

See the discussion in #1046. The issue with this PR is that it starts using the build system to generate source code, which (a) makes it no longer possible to just add the sources to a project without using CMake, and (b) requires that to support any other build system (e.g. Bazel, which I'd like to support), we'd have to duplicate this source-generating logic in that other build system also.

@pinotree If you see this, I'm open to PRs that solve the problem you were trying to solve without generating source code.

[jbeder]

Aaaand there's an unresolved linker error for the YAML::Null and YAML::detail::node::m_amount symbols. I don't get it, since they appear to be defined. But I don't have access to a Windows machine, so if anyone sees this, I'd love some help getting this PR to work.

[hkarel]

I passed the tests, but essentially I repeated my own decision about which I wrote in #1046. See my branch revert-1045-hidden-visibility-again, commits: WIP, WIP2, WIP3, WIP4
My dll.h file - it compilation from cmake-generation for GCC, MSVC, MIGW

[jbeder]

If you’re happy with the code, can you submit a PR?

…

On Fri, Nov 19, 2021 at 1:27 PM Pavel Karelin ***@***.***> wrote: I passed the tests, but essentially I repeated my own decision about which I wrote in #1046 <#1046>. See my branch revert-1045-hidden-visibility-again <https://github.com/hkarel/yaml-cpp/tree/revert-1045-hidden-visibility-again>, commits: WIP <hkarel@b8818e8>, WIP2 <hkarel@e4e735a>, WIP3 <hkarel@11f67d7>, WIP4 <hkarel@1ef0f6c> My dll.h file - it compilation from cmake-generation for GCC, MSVC, MIGW — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1063 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAICUBUMERCLSNYI5EW2LOLUM2QJDANCNFSM5IMSFUGQ> .

[hkarel]

Done. PR #1064