DownFlowpathLength: additional check if direction fall into nodata #314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #300
If the value in one pixel of the D8Pointer points into NoData, the tool won't crash but will output wrong result. This PR adds a safeguard to prevent this and inform the user that there is an issue with the input file. Alternativevly, the code could be modified in ordre to ignore such a pixel and consider it as
0but I think that it is better to not silence this kind of issue in a D8 pointer.Also, I didn't edit the message as it is still valid, but it may be more useful to the user if the message included the row and column number of the pixel causing the error.