Skip to content

DownFlowpathLength: additional check if direction fall into nodata #314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jfbourdon wants to merge 2 commits into
base: master
Choose a base branch
from
Open

DownFlowpathLength: additional check if direction fall into nodata #314

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b47fed5
check if dir fall in nodata
jfbourdon Jan 10, 2023
4932efe
remove extra space
jfbourdon Jan 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions whitebox-tools-app/src/tools/hydro_analysis/downslope_flowpath_length.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -360,15 +360,16 @@ impl WhiteboxTool for DownslopeFlowpathLength {
// find its downslope neighbour
dir = pntr.get_value(y, x);
if dir > 0f64 && dir != nodata {
if dir > 128f64 || pntr_matches[dir as usize] == 999 {
return Err(Error::new(ErrorKind::InvalidInput,
"An unexpected value has been identified in the pointer image. This tool requires a pointer grid that has been created using either the D8 or Rho8 tools."));
}
// move x and y accordingly
c = pntr_matches[dir as usize];
x += dx[c];
y += dy[c];

if dir > 128f64 || c == 999 || pntr.get_value(y, x) == nodata {
return Err(Error::new(ErrorKind::InvalidInput,
"An unexpected value has been identified in the pointer image. This tool requires a pointer grid that has been created using either the D8 or Rho8 tools."));
}

dist += grid_lengths[c] * weights.get_value(y, x) as f64;

if output.get_value(y, x) != -999f64 {
Expand Down