Skip to content

Port __format__ and tests from VSJ3 #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeff5 merged 6 commits into from
Dec 30, 2025
Merged

Port __format__ and tests from VSJ3 #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
406791f
Port float.__format__ and tests
jeff5 Dec 28, 2025
a846473
Bug-fixes to float formatting and some tests
jeff5 Dec 29, 2025
4dd7d25
Add the implementation of int.__formatter__
jeff5 Dec 29, 2025
7bc35d7
Move formatter implementations to internal module
jeff5 Dec 29, 2025
2f3d2fb
Add the implementation of str.__formatter__
jeff5 Dec 30, 2025
d390eb0
Dead code removal, renames and code motion for readability
jeff5 Dec 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions rt4core/src/main/java/uk/co/farowl/vsj4/core/Abstract.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,8 +143,8 @@ public static void setItem(Object o, Object key, Object value)
}

/**
* {@code o[i1:12] = value} with Python semantics, where {@code o} may
* be a mapping or a sequence.
* {@code o[i1:12] = value} with Python semantics, where {@code o}
* may be a mapping or a sequence.
*
* @param o object to operate on
* @param i1 index of first item in slice
Expand Down Expand Up @@ -187,8 +187,8 @@ public static void delItem(Object o, Object key) throws Throwable {
}

/**
* {@code del o[i1:12]} with Python semantics, where {@code o} may be
* a mapping or a sequence.
* {@code del o[i1:12]} with Python semantics, where {@code o} may
* be a mapping or a sequence.
*
* @param o object to operate on
* @param i1 index of first item in slice
Expand All @@ -198,7 +198,8 @@ public static void delItem(Object o, Object key) throws Throwable {
* @throws Throwable from invoked method implementations
*/
// Compare CPython PyObject_DelSlice in abstract.c
public static void delSlice(Object o, int i1, int i2) throws Throwable {
public static void delSlice(Object o, int i1, int i2)
throws Throwable {
Object key = new PySlice(i1, i2);
// Decisions are based on types of o and key
try {
Expand Down Expand Up @@ -1357,9 +1358,9 @@ static void badInternalCall() {
* should be impossible in a correct interpreter. This is a sort of
* {@link PyBaseException TypeError} against the {@code self}
* argument, but occurring where no programming error should be able
* to induce it (e.g. coercion fails after we have passed the check
* that descriptors make on their {@code obj}, or when invoking a
* special method found via an {@link Representation} object.
* to induce it. E.g. coercion failed after we have passed the check
* that descriptors make on their {@code obj}, or we invoked a
* special method found via a {@link Representation} object.
*
* @param d expected kind of argument
* @param o actual argument (not its type)
Expand Down
Loading