fix: overwrite existing environment variable#8898
Merged
jenkins-x-bot merged 1 commit intomainfrom Nov 12, 2025
Merged
Conversation
appending an environment variable doesn't do anythinh if it is already set Signed-off-by: Mårten Svantesson <Marten.Svantesson@ticket.se>
Member
Author
|
/cc tomhobson JordanGoasdoue Skisocks mentlak0 |
Member
Author
|
/retest |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8898 +/- ##
==========================================
+ Coverage 32.08% 32.11% +0.02%
==========================================
Files 10 10
Lines 1175 1174 -1
==========================================
Hits 377 377
+ Misses 755 754 -1
Partials 43 43 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Skisocks
approved these changes
Nov 12, 2025
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Skisocks The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
appending an environment variable doesn't do anything if it is already set
The problem
If the BINARY_NAME environment variable happens to be set the help text are messed up:
As compared to the correct:
This PR fixes that:
TOP_LEVEL_COMMAND has basically the same function as BINARY_NAME; some plugins use one and some the other.