Skip to content

fix: overwrite existing environment variable #8898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jenkins-x-bot merged 1 commit into from
Nov 12, 2025
Merged

fix: overwrite existing environment variable #8898

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions pkg/cmd/root.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,11 +272,10 @@ func handleEndpointExtensions(cmdArgs []string, pluginBinDir string) error {

// Giving plugin information about how it was invoked, so it can give correct help
pluginCommandName := os.Args[0] + " " + strings.Join(remainingArgs, " ")
environ := append(os.Environ(),
fmt.Sprintf("BINARY_NAME=%s", pluginCommandName),
fmt.Sprintf("TOP_LEVEL_COMMAND=%s", pluginCommandName))
os.Setenv("BINARY_NAME", pluginCommandName)
os.Setenv("TOP_LEVEL_COMMAND", pluginCommandName)
// invoke cmd binary relaying the current environment and args given
// remainingArgs will always have at least one element.
// execute will make remainingArgs[0] the "binary name".
return plugins.Execute(foundBinaryPath, nextArgs, environ)
return plugins.Execute(foundBinaryPath, nextArgs, os.Environ())
}