Skip to content

Simplify card UI#1022

Merged
timja merged 3 commits intojenkinsci:masterfrom
timja:improve-card-ui
Feb 25, 2026
Merged

Simplify card UI#1022
timja merged 3 commits intojenkinsci:masterfrom
timja:improve-card-ui

Conversation

@timja
Copy link
Member

@timja timja commented Feb 21, 2026

  • Makes the ID as the most recognisable primary element
  • Include the name as a secondary element
    • Hidden if the name is the same as the ID or the description as they are shown elsewhere
    • Bit of a hack: Remove the description from the name as its shown elsewhere

I can see why you would want to include the description in the c:select dropdown with the name, which is why some credentials have it in their name provider, but for the credentials list its not great so I've stripped it out.

Fixes #1004

(Similar should be done on the view credentials page, I'll do that separately)

Testing done

Tested various credentials

Store

Before:

image

After:

image

View credentials action

Before:

image

After:

image

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests that demonstrate the feature works or the issue is fixed

@timja timja requested a review from janfaracik February 21, 2026 22:32
@timja timja marked this pull request as ready for review February 21, 2026 22:32
@timja timja requested a review from a team as a code owner February 21, 2026 22:32
Comment on lines +43 to +46
display: flex;
flex-direction: column;
justify-content: center;
min-height: 3.5rem;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on the store page the description can be empty which didn't look great, this centres the title if there's no description. It also ensures that all the cards are the same size even if there's no description.

Without this change:
image

@alexsch01
Copy link

Looks great!

@janfaracik
Copy link
Member

image

Spacing is a little broken with this

@timja
Copy link
Member Author

timja commented Feb 23, 2026

Fixed:
image

Copy link
Member

@janfaracik janfaracik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM.

@timja timja merged commit 6d6145e into jenkinsci:master Feb 25, 2026
19 checks passed
@timja timja deleted the improve-card-ui branch February 25, 2026 11:23
@alexsch01
Copy link

Great change!! Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[card layout since 1458.v7291f840651c] prefer to have ID to be the header/title

3 participants