Skip to content

Simplify card UI #1022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timja merged 3 commits into from
Feb 25, 2026
Merged

Simplify card UI #1022

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cd49506
Simplify card UI
timja Feb 21, 2026
b5e11ec
Center element when no description to show
timja Feb 21, 2026
757dec1
Fix split card layout
timja Feb 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/main/java/com/cloudbees/plugins/credentials/CredentialsStoreAction.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1078,6 +1078,16 @@ public String getDisplayName() {
return CredentialsNameProvider.name(credentials);
}

/**
* Description is useful for select drop down in the name but not in the credentials list.
* So remove the description so we have more control over how its displayed.
*/
@Restricted(NoExternalUse.class)
@SuppressWarnings("unused") // jelly
public String getCleanedName() throws IOException {
return getDisplayName().replace("(" + getDescription() + ")", "");
}

/**
* Gets the display name of the {@link CredentialsDescriptor}.
*
Expand Down
10 changes: 10 additions & 0 deletions src/main/java/com/cloudbees/plugins/credentials/ViewCredentialsAction.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -514,6 +514,16 @@ public String getName() {
return CredentialsNameProvider.name(credentials);
}

/**
* Description is useful for select drop down in the name but not in the credentials list.
* So remove the description so we have more control over how its displayed.
*/
@Restricted(NoExternalUse.class)
@SuppressWarnings("unused") // jelly
public String getCleanedName() throws IOException {
return getName().replace("(" + getDescription() + ")", "");
}

/**
* Returns the {@link StandardCredentials#getDescription()} of the {@link #credentials}.
*
Expand Down
17 changes: 10 additions & 7 deletions ...ources/com/cloudbees/plugins/credentials/CredentialsStoreAction/DomainWrapper/index.jelly
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,17 +99,20 @@
<div class="credentials-card__inner">
<div class="credentials-card__title">
<l:icon class="${c.iconClassName}" tooltip="${c.typeName}"/>
<a href="credential/${c.urlName}">${c.displayName}</a>
</div>
<a href="credential/${c.urlName}">${c.id}</a>

<div class="credentials-card__details">
<span>${c.id}</span>
<j:if test="${!empty(safeDescription)}">
<span>-</span>
<span>${safeDescription}</span>
<j:set var="name" value="${c.cleanedName}"/>
<j:if test="${name ne null and name ne c.id and name ne c.description}">
<span class="credentials-card__tags">${name}</span>
</j:if>
</div>

<j:if test="${!empty(safeDescription)}">
<div class="credentials-card__details">
<span>${safeDescription}</span>
</div>
</j:if>

</div>
<div class="credentials-card__controls">
<j:if test="${h.hasPermission(c, it.parent.UPDATE)}">
Expand Down
8 changes: 5 additions & 3 deletions src/main/resources/com/cloudbees/plugins/credentials/ViewCredentialsAction/index.jelly
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,8 +119,12 @@
<div class="credentials-card__title">
<l:icon class="${d.iconClassName}" tooltip="${d.kind}"/>
<a href="${(storeAction==null?d.store.getRelativeLinkTo(d.domain):d.store.relativeLinkToContext+'credentials/store/'+storeAction.urlName+'/'+d.domain.url)+'credential/'+d.id}">
${d.name}
${d.id}
</a>
<j:set var="name" value="${d.cleanedName}"/>
<j:if test="${name ne null and name ne d.id and name ne d.description}">
<span class="credentials-card__tags">${name}</span>
</j:if>
</div>
<div class="credentials-card__details">
<a href="${storeAction==null?d.store.relativeLinkToAction:d.store.relativeLinkToContext+'credentials/store/'+storeAction.urlName}">
Expand All @@ -138,8 +142,6 @@
</j:otherwise>
</j:choose>
</a>
<span>-</span>
${d.id}
<j:if test="${!empty(safeDescription)}">
<span>-</span>
${safeDescription}
Expand Down
5 changes: 5 additions & 0 deletions src/main/resources/com/cloudbees/plugins/credentials/common/card.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,11 +40,16 @@

.credentials-card__inner {
padding: 0.75rem 1rem;
display: flex;
flex-direction: column;
justify-content: center;
min-height: 3.5rem;
Comment on lines +43 to +46
Copy link
Member Author

@timja timja Feb 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on the store page the description can be empty which didn't look great, this centres the title if there's no description. It also ensures that all the cards are the same size even if there's no description.

Without this change:
image

}

.credentials-card__inner--split {
display: grid;
grid-template-columns: 350px 1fr;
min-height: unset;
}

.credentials-card__details {
Expand Down
Loading