Bump io.jenkins.tools.bom:bom-2.479.x from 3944.v1a_e4f8b_452db_ to 4228.v0a_71308d905b_#145
Conversation
Bumps [io.jenkins.tools.bom:bom-2.479.x](https://github.com/jenkinsci/bom) from 3944.v1a_e4f8b_452db_ to 4228.v0a_71308d905b_. - [Release notes](https://github.com/jenkinsci/bom/releases) - [Commits](https://github.com/jenkinsci/bom/commits) --- updated-dependencies: - dependency-name: io.jenkins.tools.bom:bom-2.479.x dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
added
dependencies
MarkEWaite
left a comment
MarkEWaite
left a comment
There was a problem hiding this comment.
@dependabot squash and merge
|
One of your CI runs failed on this pull request, so Dependabot won't merge it. Dependabot will still automatically merge this pull request if you amend it and your tests pass. |
Windows agents on ci.jenkins.io have a different character set configuration than Windows agents on the Azure configuration of ci.jenkins.io. Similar issue was reported by Bobby Sandell for another plugin. Easy to modify this test to not exercise that path. jenkins-infra/helpdesk#4568 is the Jenkins infra help desk issue report.
dependabot
bot
deleted the
dependabot/maven/io.jenkins.tools.bom-bom-2.479.x-4228.v0a_71308d905b_
branch
| assertTrue(isListBoxItem(items, "00a8385cba1e4e32cf823775e2b3dbe5eb27931d")); | ||
| assertTrue(isListBoxItemName( | ||
| items, "00a8385c 2011-10-30 17:11 Łukasz Miłkowski <lukanus@uaznia.net> initial readme")); | ||
| if (!Functions.isWindows() || System.getenv("CI") == null) { |
There was a problem hiding this comment.
jenkins-infra/helpdesk#4568 (comment) Rather than checking either the OS or the CI/local environment, I would think this test should either be fixed to pass in whatever encoding it happens to be run in, or to skip this assertion (or use Assume to skip the test case) in case that is impossible for some reason. I am not familiar enough with the plugin to have an opinion which it should be.
There was a problem hiding this comment.
I've adjusted the test to remove the character set dependency. I don't think that the test intended to check for character set dependencies.
2 participants
Bumps io.jenkins.tools.bom:bom-2.479.x from 3944.v1a_e4f8b_452db_ to 4228.v0a_71308d905b_.
Release notes
Sourced from io.jenkins.tools.bom:bom-2.479.x's releases.
... (truncated)
Commits
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot will merge this PR once CI passes on it, as requested by @MarkEWaite.
Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)