Modernized package by using pyproject.toml instead of setup.py#206
Merged
speleo3 merged 3 commits intojensengroup:masterfrom Feb 25, 2026
Merged
Modernized package by using pyproject.toml instead of setup.py#206speleo3 merged 3 commits intojensengroup:masterfrom
speleo3 merged 3 commits intojensengroup:masterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR modernizes PROPKA’s Python packaging by migrating project metadata and tool configuration into pyproject.toml, reducing reliance on legacy setup.py/setup.cfg configuration and improving compatibility with modern tooling (e.g., uv, PEP 517 builds).
Changes:
- Added
pyproject.tomlwith PEP 621 project metadata, setuptools configuration, and tool configs (versioneer/coverage/yapf/mypy). - Simplified
setup.pyto only provide Versioneer-driven version + cmdclass. - Removed
setup.cfg, added a dedicated long description markdown file, and updatedMANIFEST.inpruning.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| setup.py | Reduced to minimal Versioneer integration for dynamic versioning. |
| setup.cfg | Removed in favor of pyproject.toml tool configuration. |
| pyproject.toml | New single source of truth for packaging metadata + tool configs. |
| MANIFEST.in | Prunes docs/tests; needs alignment with removed/added packaging files. |
| LONG_DESCRIPTION.md | New long description file referenced by pyproject.toml. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
I fixed the suggestions of copilot. Let me know if you want me to also remove versioneer in favor of setuptools-scm https://setuptools-scm.readthedocs.io/en/latest/ which works without adding any files in the repository. |
sobolevnrm
approved these changes
Feb 9, 2026
speleo3
approved these changes
Feb 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This modernizes the python packaging of propka. It's also useful for newer tools like
uvwhich don't work without the pyproject.toml file. With this change you can just douv run pytestin the folder and it creates the env and runs the tests.In theory I can also get rid of versioneer if you want by jsut adding setuptools-scm to the build-system (which would allow us to remove the remaining setup.py as well as the versioneer.py and version.py files). I didn't do it here to not intervene too much but if you want I am more than happy to add the change.