Skip to content

Conversation

@phanen
Copy link
Contributor

@phanen phanen commented Dec 30, 2025

  • fix: ctrl-i don't work after fec7e9c
  • fix: missing readline keybind in commit editor

PR Description

After updating from source I notice many keybind broken.
Because a recent bump of gocui/tcell.

gocui pr: jesseduffield/gocui#92

Please check if the PR fulfills these requirements

  • Cheatsheets are up-to-date (run go generate ./...)
  • Code has been formatted (see here)
  • Tests have been added/updated (see here for the integration test guide)
  • Text is internationalised (see here)
  • If a new UserConfig entry was added, make sure it can be hot-reloaded (see here)
  • Docs have been updated if necessary
  • You've read through your own file changes for silly mistakes etc

tcell now can distinguish them
phanen/tcell@74fd487

I always use c-i as tab key, to resume the behavior, this commit allow:
togglePanel: <c-i>
ctrl-b/ctrl-f commit here: 6422b39
Didn't port to gocui, disappear in
bb816d7

Add ctrl-h because not it's no longer recgnoized as backspace since
(tcell distinguish them).
@phanen phanen marked this pull request as draft December 30, 2025 12:48
Comment on lines +55 to +60
gocui.KeyCtrlH: "<c-h>",
gocui.KeyCtrlI: "<c-i>",
gocui.KeyCtrlJ: "<c-j>",
gocui.KeyCtrlK: "<c-k>",
gocui.KeyCtrlL: "<c-l>",
gocui.KeyCtrlM: "<c-m>",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't want to add any of these to the list just yet. The upgrade of tcell allows us to have many more available keybindings (e.g. <s-c-a-pgup>), but we need some changes to our keybinding infrastructure to handle these. And they will only be available if the terminal supports the new key event protocol, so we need to find a way to warn the user if theirs doesn't. I'm working on this (slowly, might take a few more weeks), and I want to add these missing keybindings then.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Now for me the only missing part is to make can work as tab in lazygit (togglePanel). Which I think you will resolve later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants