Skip to content

fix ctrl-i/ctrl-h/ctrl-b/ctrl-f #5149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
phanen wants to merge 2 commits into
base: master
Choose a base branch
from
+6 −3
Draft

fix ctrl-i/ctrl-h/ctrl-b/ctrl-f #5149

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
39200b5
fix: ctrl-i don't work after fec7e9ce
phanen Dec 30, 2025
efbc4ed
fix: missing readline keybind in commit editor
phanen Dec 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions pkg/config/keynames.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,9 +52,12 @@ var LabelByKey = map[gocui.Key]string{
gocui.KeyCtrlE: "<c-e>",
gocui.KeyCtrlF: "<c-f>",
gocui.KeyCtrlG: "<c-g>",
gocui.KeyCtrlH: "<c-h>",
gocui.KeyCtrlI: "<c-i>",
gocui.KeyCtrlJ: "<c-j>",
gocui.KeyCtrlK: "<c-k>",
gocui.KeyCtrlL: "<c-l>",
gocui.KeyCtrlM: "<c-m>",
Comment on lines +55 to +60
Copy link
Collaborator

@stefanhaller stefanhaller Jan 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't want to add any of these to the list just yet. The upgrade of tcell allows us to have many more available keybindings (e.g. <s-c-a-pgup>), but we need some changes to our keybinding infrastructure to handle these. And they will only be available if the terminal supports the new key event protocol, so we need to find a way to warn the user if theirs doesn't. I'm working on this (slowly, might take a few more weeks), and I want to add these missing keybindings then.

Copy link
Contributor Author

@phanen phanen Jan 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Now for me the only missing part is to make can work as tab in lazygit (togglePanel). Which I think you will resolve later.

gocui.KeyCtrlN: "<c-n>",
gocui.KeyCtrlO: "<c-o>",
gocui.KeyCtrlP: "<c-p>",
Expand Down
6 changes: 3 additions & 3 deletions vendor/github.com/jesseduffield/gocui/edit.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading