ci: get smoketest workflow passing again #1790
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimenB
reviewed
Jul 2, 2025
| - uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: 16 | ||
| node-version: 20 |
There was a problem hiding this comment.
Suggested change
| node-version: 20 | |
| node-version: lts/* |
There was a problem hiding this comment.
This intentionally uses the oldest version of node we support to ensure compatibility
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
npmerrors as we've technically got peer dependency violations due tojest-runner-eslintnot officially supporting Jest v30 (or ESLint v9 for that matter), so I've finally switched us to using Yarn to setup this job.This has also revealed that we might not yet be able to use v2 of the repositories package so I've downgraded that for now but will revisit once the job is working again