Skip to content

ci: get smoketest workflow passing again #1790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jul 1, 2025
Merged

ci: get smoketest workflow passing again #1790

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
1e0da0c
ci: run workflow
G-Rath Jul 1, 2025
707603d
ci: run on one repo
G-Rath Jul 1, 2025
1bd4d4b
ci: use Node v20
G-Rath Jul 1, 2025
81b354f
ci: use yarn
G-Rath Jul 1, 2025
4e490b0
ci: downgrade smoke test repos
G-Rath Jul 1, 2025
ad00037
ci: make a symlink manually
G-Rath Jul 1, 2025
5524cd9
ci: run against all repos
G-Rath Jul 1, 2025
c20817e
ci: remove unneeded `yarn link`
G-Rath Jul 1, 2025
086a3e0
ci: cache yarn dependencies
G-Rath Jul 1, 2025
ddf81c7
ci: skip branch
G-Rath Jul 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .github/workflows/smoke-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,12 +22,12 @@ jobs:
persist-credentials: false
- uses: actions/setup-node@v4
with:
node-version: 16
node-version: 20
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
node-version: 20
node-version: lts/*

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This intentionally uses the oldest version of node we support to ensure compatibility

cache: 'yarn'
- run: |
npm install --legacy-peer-deps
npm run build
npm link
npm link eslint-plugin-jest
yarn install
yarn build
ln -s ../ node_modules/eslint-plugin-jest
- uses: AriPerkkio/eslint-remote-tester-run-action@v4
with:
issue-title: 'Results of weekly scheduled smoke test'
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@
"eslint-plugin-n": "^17.0.0",
"eslint-plugin-prettier": "^5.0.0",
"eslint-remote-tester": "^3.0.0",
"eslint-remote-tester-repositories": "~2.0.0",
"eslint-remote-tester-repositories": "^1.0.0",
"husky": "^9.0.1",
"is-ci": "^4.0.0",
"jest": "^30.0.0",
Expand Down
10 changes: 5 additions & 5 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5295,7 +5295,7 @@ __metadata:
eslint-plugin-n: "npm:^17.0.0"
eslint-plugin-prettier: "npm:^5.0.0"
eslint-remote-tester: "npm:^3.0.0"
eslint-remote-tester-repositories: "npm:~2.0.0"
eslint-remote-tester-repositories: "npm:^1.0.0"
husky: "npm:^9.0.1"
is-ci: "npm:^4.0.0"
jest: "npm:^30.0.0"
Expand Down Expand Up @@ -5361,10 +5361,10 @@ __metadata:
languageName: node
linkType: hard

"eslint-remote-tester-repositories@npm:~2.0.0":
version: 2.0.1
resolution: "eslint-remote-tester-repositories@npm:2.0.1"
checksum: 10c0/0efae02033c86258057550c4032bcb5bc41f37678e742630c003a73138ac68cad894b70e0664c39cee3d5f904c870eec4d32a024f2f39cb041884fc39ceab906
"eslint-remote-tester-repositories@npm:^1.0.0":
version: 1.0.1
resolution: "eslint-remote-tester-repositories@npm:1.0.1"
checksum: 10c0/ac3c097f83b0e1bd19b7863c986522a290673c2918c23507cebe77a8d45706a75e6f1ec622d203b610c5176834f485e2b3b96e204e1fc61ba2f5665ec113ce88
languageName: node
linkType: hard

Expand Down