Skip to content

Conversation

jay-aye-see-kay
Copy link
Contributor

Summary

Currently when if GITHUB_TOKEN is set to an expired or invalid token requests to github will fail with a 404. There is not messaging to the user (even with DEVBOX_DEBUG=1) to indicate the cause. This took a while to debug, opening this PR to make it easier for the next person this happens to.

How was it tested?

❯ devbox install

Error: failed to get plugin github:jetpack-io/devbox-plugins?dir=mongodb @ https://raw.githubusercontent.com/jetpack-io/devbox-plugins/master/mongodb/plugin.json (Status code 404). 
Please make sure a plugin.json file exists in plugin directory.
  • now using code in this PR
❯ ../dist/devbox install

Error: failed to get plugin github:jetpack-io/devbox-plugins?dir=mongodb @ https://raw.githubusercontent.com/jetpack-io/devbox-plugins/master/mongodb/plugin.json (Status code 404).
The auth header `token gh_1*********` was send with this request.
Please make sure a plugin.json file exists in plugin directory.

Community Contribution License

All community contributions in this pull request are licensed to the project
maintainers under the terms of the
Apache 2 License.

By creating this pull request, I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 License as stated in
the
Community Contribution License.

Copy link
Collaborator

@savil savil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for sending this!

Will let cicd tests run and pass prior to landing

@savil savil requested review from gcurtis and mikeland73 March 27, 2025 17:06
@Lagoja Lagoja merged commit 2017ed6 into jetify-com:main Apr 8, 2025
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants