chore(ui): Clean new keyboard option #495
Conversation
IDisposable
force-pushed
the
chore/css-fix
branch
from
916ed3e to
0512673
Compare
|
Reverted the comment. |
IDisposable
force-pushed
the
chore/css-fix
branch
from
0512673 to
b9669ff
Compare
| @@ -25,7 +25,7 @@ export default function SettingsKeyboardRoute() { | |||
| if ("error" in resp) return; | |||
| setKeyboardLayout(resp.result as string); | |||
| }); | |||
| }, []); // eslint-disable-line react-hooks/exhaustive-deps | |||
| }, [send, setKeyboardLayout]); | |||
There was a problem hiding this comment.
This change at minimum needs to be landed somehow. As it stand without those dependencies listed we're going send("getKeyboardLayout" message and call the get setKeyboardLayout(` every single render cycle.
☝️ @adamshiervani
There was a problem hiding this comment.
@ym, this really needs to be merged... tons of React rerenders until we do...
There was a problem hiding this comment.
Empty dependencies mean that it will behave like componentDidMount, running only once when the component mounts. I can also confirm that it does not re-render outside the case mentioned above.
IDisposable
force-pushed
the
chore/css-fix
branch
2 times, most recently
from
fecdfd6 to
5911b8a
Compare
Fixed the Tailwind CSS syntax for `in` (nested) selector Added missing React dependency for `useEffect`
IDisposable
force-pushed
the
chore/css-fix
branch
from
5911b8a to
05cc4a1
Compare
| @@ -25,7 +25,7 @@ export default function SettingsKeyboardRoute() { | |||
| if ("error" in resp) return; | |||
| setKeyboardLayout(resp.result as string); | |||
| }); | |||
| }, []); // eslint-disable-line react-hooks/exhaustive-deps | |||
| }, [send, setKeyboardLayout]); | |||
There was a problem hiding this comment.
Empty dependencies mean that it will behave like componentDidMount, running only once when the component mounts. I can also confirm that it does not re-render outside the case mentioned above.
Fixed the Tailwind CSS syntax for `in` (nested) selector Added missing React dependency for `useEffect`
Fixed the Tailwind CSS syntax for `in` (nested) selector Added missing React dependency for `useEffect`
Fixed the Tailwind CSS syntax for
in(nested) selectorAdded missing React dependency for
useEffect