feat: add cluster uid derived from kube-system ns#670
Merged
wallrj-cyberark merged 2 commits intomasterfrom Aug 6, 2025
Merged
feat: add cluster uid derived from kube-system ns#670wallrj-cyberark merged 2 commits intomasterfrom
wallrj-cyberark merged 2 commits intomasterfrom
Conversation
This seems like a simple enough way of uniquely identifying a cluster. Google searches show that this pattern is used elsewhere. It seems fair to assume that if the kube-system ns UID changes, it implies that the cluster changed enough to be considered different anyway! This is added to the context so it can be used elsewhere, on the assumption that it can be determined at startup and won't change later. We'll use this for "machinehub mode" soon. Signed-off-by: Ashley Davis <ashley.davis@cyberark.com>
Signed-off-by: Richard Wall <richard.wall@cyberark.com>
Member
|
I've tested this and observed the new clusterUID is logged at startup, with a GKE cluster: $ ./hack/e2e/test.sh
...
{
"ts": 1753372212871.0688,
"caller": "agent/run.go:101",
"msg": "Retrieved cluster UID",
"v": 1,
"logger": "Run",
"clusterUID": "da59b2ea-a06f-4c7f-bb91-038222eb6f73"
}
...
{"ts":1753372219356.0215,"caller":"agent/run.go:460","msg":"Data sent successfully","v":0,"logger":"Run.gatherAndOutputData.postData"}
...
I don't think that's acceptable. The cluster UID is only needed for the machinhub integration so it should at least be confined to that branch.
I won't merge it until we have a branch ready to show how this will be used. |
wallrj-cyberark
approved these changes
Aug 6, 2025
Member
wallrj-cyberark
left a comment
There was a problem hiding this comment.
I've been testing this in #678 and it works well.
I'll remove the temporary panic statements in a followup PR, along with some other changes to the Machine Hub / Discovery Context API wrapper
This was referenced Aug 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This seems like a simple enough way of uniquely identifying a cluster. Google searches show that this pattern is used elsewhere.
It seems fair to assume that if the kube-system ns UID changes, it implies that the cluster changed enough to be considered different anyway!
This is added to the context so it can be used elsewhere, on the assumption that it can be determined at startup and won't change later. We'll use this for "machinehub mode" soon.
Possible work still needed (i.e., we need to decide if the below are acceptable before we merge):
panicing?