Enable ServiceMonitor by default, if available #320
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hawksight
reviewed
Mar 25, 2025
| apiVersions: | ||
| - "monitoring.coreos.com/v1/ServiceMonitor" | ||
| set: | ||
| serviceMonitor.enabled: true |
Member
There was a problem hiding this comment.
You could probably remove this line, from this test if enabled by default?
hawksight
approved these changes
Mar 25, 2025
Member
hawksight
left a comment
hawksight
left a comment
There was a problem hiding this comment.
Looks like a good change. Only one very minor nit, feel free to ignore as it has no impact :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As with #300 - It can become challenging for new users on getting started, therefore I propose we change the way that
we deploy the ServiceMonitor resource, if there is a ServiceMonitor in the cluster.
The ServiceMonitor can be disabled via the same valye
serviceMonitor.enabledand setting it tofalse.N.B: This IMO would be a minor release vs patch