Limit ReservedThread creation #13837
Open
+14
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oleksandr Krutko <[email protected]>
sbordet
requested changes
Oct 23, 2025
| } | ||
| else if (maxPending == 0) | ||
| { | ||
| _maxPending = reservedThreads(executor, capacity); |
There was a problem hiding this comment.
Suggested change
| _maxPending = reservedThreads(executor, capacity); | |
| _maxPending = _threads.capacity(); |
| * is calculated based on a heuristic from the number of available processors and | ||
| * thread pool type. | ||
| * @param minSize The minimum number of reserve Threads that the algorithm tries to maintain, or -1 for a heuristic value. | ||
| * @param maxPending The maximum number of reserved Threads to start, or -1 for no limit. |
There was a problem hiding this comment.
Please update the javadoc with the meaning of the value 0.
| throw new IllegalArgumentException("maxPending cannot be 0"); | ||
|
|
||
| if (maxPending < 0) | ||
| { |
There was a problem hiding this comment.
Remove the braces for these one-line if/else statements.
|
@arsenalzp also please change the 3-parameters constructor to pass 0 as default value, not -1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes issue #13707