Skip to content

Limit ReservedThread creation #13837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: jetty-12.1.x
Choose a base branch
from
Open

Limit ReservedThread creation #13837

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions ...y-core/jetty-util/src/main/java/org/eclipse/jetty/util/thread/ReservedThreadExecutor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,9 +92,20 @@ public ReservedThreadExecutor(Executor executor, int capacity, int minSize, int
_minSize = minSize < 0 ? Math.min(1, _threads.capacity()) : minSize;
if (_minSize > _threads.capacity())
throw new IllegalArgumentException("minSize larger than capacity");
_maxPending = maxPending;
if (_maxPending == 0)
throw new IllegalArgumentException("maxPending cannot be 0");

if (maxPending < 0)
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the braces for these one-line if/else statements.

_maxPending = -1;
}
else if (maxPending == 0)
{
_maxPending = reservedThreads(executor, capacity);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
_maxPending = reservedThreads(executor, capacity);
_maxPending = _threads.capacity();

}
else
{
_maxPending = maxPending;
}

if (LOG.isDebugEnabled())
LOG.debug("{}", this);
installBean(_executor);
Expand Down