-
Notifications
You must be signed in to change notification settings - Fork 32
Add GitHub Actions summary for the create evidence command #112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ef70f1c to
99f5794
Compare
7fd425b to
2c3acf1
Compare
| "regexp" | ||
| "strings" | ||
|
|
||
| clientLog "github.com/jfrog/jfrog-client-go/utils/log" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is it different than other places in the code?
| CreatedAt string `json:"created_at"` | ||
| CreatedBy string `json:"created_by"` | ||
| Verified bool `json:"verified"` | ||
| ProviderId string `json:"provider_id"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note to self, don't forget to add stage
| SubjectType: commandsummary.SubjectTypeReleaseBundle, | ||
| ReleaseBundleName: c.releaseBundle, | ||
| ReleaseBundleVersion: c.releaseBundleVersion, | ||
| RepoKey: utils.BuildReleaseBundleRepoKey(c.project), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are those needed: CreatedAt? CreatedBy? ProviderId?
| Verified: response.Verified, | ||
| DisplayName: displayName, | ||
| SubjectType: commandsummary.SubjectTypePackage, | ||
| RepoKey: c.packageService.GetPackageRepoName(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CreatedAt? CreatedBy? ProviderId?
|
|
||
| func (c *createEvidenceCustom) recordSummary(response *model.CreateResponse) { | ||
| commandSummary := commandsummary.EvidenceSummaryData{ | ||
| Subject: c.subjectRepoPath, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RepoKey? CreatedAt? CreatedBy? ProviderId?
| BuildName: c.buildName, | ||
| BuildNumber: c.buildNumber, | ||
| BuildTimestamp: timestamp, | ||
| RepoKey: utils.BuildBuildInfoRepoKey(c.project), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CreatedBy? CreatedAt? ProviderId?
7fbbd16 to
8f52f88
Compare
Description
Add evidence summary section for Create Evidence Command
This PR is part of a series of three that enhances the documentation for the "create evidence" command by introducing a summary markdown table.
jfrog-cli-core PR: jfrog/jfrog-cli-core#1423
jfrog-cli PR: jfrog/jfrog-cli#3042
Summary
This addition aims to improve the user experience by providing a clear and concise overview of the evidence being created. The markdown table includes the following columns:
Evidence Subject: Links to the relevant evidence files, allowing users to easily access them.
Evidence Type: Specifies the type of evidence being recorded (e.g., in-toto).
Verification Status: Indicates whether the evidence has been verified, complete with visual status indicators (e.g., ✅ Verified).
Example Output
When the create evidence command is executed, users will see a collapsible section that looks like this:
🔎 Evidence