Fix rbc command to accept project argument
#1356
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
EyalDelarea
suggested changes
Feb 25, 2025
common/spec/specfiles_test.go
Outdated
| func TestCreateSpecFromBuildNameAndNumber(t *testing.T) { | ||
| t.Run("Valid Inputs", func(t *testing.T) { | ||
| spec, err := CreateSpecFromBuildNameAndNumber("Common-builds", "1.2.0") | ||
| spec, err := CreateSpecFromBuildNameAndNumber("Common-builds", "1.2.0", "test") |
Contributor
There was a problem hiding this comment.
Let's extract the logic of projects key into a different test function
or we should change the name to TestCreateSpecFromBuildNameAndNumberAndProjectKey, which seems a bit long :)
Contributor
Author
There was a problem hiding this comment.
Updated as TestCreateSpecFromBuildNameNumberAndProjectKey
EyalDelarea
changed the title
EyalDelarea
changed the title
rbc command to accept project argument
EyalDelarea
approved these changes
Feb 26, 2025
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.