Refactor/stepper api motion control driver #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rename stepper-controller.yaml to stepper.yaml Signed-off-by: Jilay Pandya <[email protected]>
jilaypandya
force-pushed
the
refactor/stepper_api_motion_control_driver
branch
3 times, most recently
from
c04d44a to
5e35efd
Compare
Currently Stepper Driver API combines two different motion control and the actual stepping of a motor behind a single API. However, these are two different areas and hence need to be seperated considering that there motion controllers out there which just do motion control and interface via step/dir with a step/dir driver Signed-off-by: Jilay Pandya <[email protected]>
jilaypandya
force-pushed
the
refactor/stepper_api_motion_control_driver
branch
6 times, most recently
from
a8f3ef3 to
4306e99
Compare
This commit integrates timing source from by refactoring it out from step_dir lib Refactor motion control related function from gpio_stepper_controller to zephyr stepper control driver Remove unnecessary `data` parameter from `STEP_DIR_STEPPER_STRUCT_CHECK` macro, simplifying its usage. Adjust `tmc22xx_data` struct and initialization to reflect the change, removing redundant `.common` field. Correct the GPIO pin states for enabling and disabling the stepper motor controller. The enable logic was accidentally inverted, causing improper activation and deactivation of the device. This change ensures proper functionality as per the intended design. Signed-off-by: Andre Stefanov <[email protected]> Signed-off-by: Jilay Pandya <[email protected]>
refactor tmc50xx stepper driver into tmc50xx_stepper_driver and tmc50xx_stepper_control Signed-off-by: Jilay Pandya <[email protected]>
jilaypandya
force-pushed
the
refactor/stepper_api_motion_control_driver
branch
from
edfd048 to
7f0143f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test