Open
Conversation
Owner
|
Thanks for contributing this! Understandable about the test suite. At some point this will be merged back into the broader Kundaje-lab suite of tools and hopefully someone there will be able to incorporate this. |
Contributor
|
Hi @Turakar, tfmodisco-lite has been merged into the official TF-MoDISco repository. We encourage you to re-open your PR there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basically, I went through the code and put an if-else-statement around everything which was looking at both forward and reverse strands.
I tested these changes with my own examples, and I do not have an extensive test suite, neither is one available in the repository.
Fixes #56