Skip to content

Fix max_seqlets_subsample bug #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lhqing wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix max_seqlets_subsample bug #60

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ab5b46f
Fix max_seqlets_subsample bug
lhqing Feb 26, 2025
fbaa4c0
Merge branch 'jmschrei:main' into main
lhqing Aug 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions modiscolite/aggregator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ def _detect_spurious_merging(patterns, track_set, perplexity,
prob_and_pertrack_sim_merge_thresholds=prob_and_pertrack_sim_merge_thresholds,
prob_and_pertrack_sim_dealbreaker_thresholds=prob_and_pertrack_sim_dealbreaker_thresholds,
min_frac=min_frac, min_num=min_num, flank_to_add=flank_to_add, window_size=window_size,
bg_freq=bg_freq, max_seqlets_subsample=1000)
bg_freq=bg_freq, max_seqlets_subsample=max_seqlets_subsample)

to_return.extend(refined_subpatterns[0])
else:
Expand All @@ -197,7 +197,7 @@ def _detect_spurious_merging(patterns, track_set, perplexity,
prob_and_pertrack_sim_merge_thresholds=prob_and_pertrack_sim_merge_thresholds,
prob_and_pertrack_sim_dealbreaker_thresholds=prob_and_pertrack_sim_dealbreaker_thresholds,
min_frac=min_frac, min_num=min_num, flank_to_add=flank_to_add, window_size=window_size,
bg_freq=bg_freq, max_seqlets_subsample=1000)
bg_freq=bg_freq, max_seqlets_subsample=max_seqlets_subsample)

def SimilarPatternsCollapser(patterns, track_set,
min_overlap, prob_and_pertrack_sim_merge_thresholds,
Expand Down Expand Up @@ -502,4 +502,4 @@ def SimilarPatternsCollapser(patterns, track_set,
current_level_nodes = next_level_nodes

return patterns, PatternMergeHierarchy(root_nodes=current_level_nodes)