Open
Conversation
Author
|
Hi @jmschrei, Did you have a chance to review this pull request? I'm looking forward to your feedback. |
Owner
|
Sorry about the delay. I just started a new position yesterday and am working through a backlog. Separately, the Kundaje Lab is also working on a big blob of deliverables due mid September, so these PRs are unlikely to make it into a released version before then. |
Contributor
|
Hey @MuhammedHasan, tfmodisco-lite has been merged into the official TF-MoDISco repository. We encourage you to re-open your PR there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements:
381cf29 unit tested and cli refactored with click: See the unit-test which check results are exactly same with original. You can rerun this test-case in each downstream commits to confirm results are exactly same.