Add namespace to chart, support for custom namespace#180
Add namespace to chart, support for custom namespace#180kruchkov-alexandr wants to merge 2 commits intojoe-elliott:masterfrom
Conversation
|
@joe-elliott hey |
|
howdy! thanks for the PR. i've been meaning to get to this. i think my only question is: will this impact folks who have installed cert-exporter in namespaces besides "monitoring" when they go to upgrade? |
|
It shouldn't be an issue at all, as far as I understand. |
|
I just don't really know much about helm and this chart is basically community maintained. I do value not changing things unnecessarily if its basically working for folks. If this is a valuable improvement I'll merge it, but I need to know it won't negatively impact people currently using the chart. |
|
hey @kruchkov-alexandr 😄 Would you mind making the namespace optional (e.g. using if/with) in the helm-chart? Since it's not a required field in the underlying k8s spec that would make it a non-breaking change for folks who don't have the namespace set currently. I often work with Bearer tokens that are only entitled for certain namespaces and like the minimal approach of the current helmchart. If this was optional my setup wouldn't be concerned/affected at all - with the current implementation it would be a breaking change as I'd need to set the namespace for each deployment of cert-exporter :/ |
Summary of Changes
namespacefield tocert-manager.yaml,service.yaml, andvalues.yamlwith a default value ofmonitoring.tagfield invalues.yamlcustomizable, defaulting to.Chart.AppVersion.These changes enhance flexibility for namespace configuration and image tag management.
Local tests for another namespace: