-
Notifications
You must be signed in to change notification settings - Fork 335
Add support for room humidity VRC700 #521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
VRC720 and VR92 - I use latest config files and thy dont support humidity. Could you add the support as well? |
|
@Miecholek I think this is only for VCR700. That would be a another pull request in my opinion. My question here is: Why is there no review happening? The change looks straight forward to me. |
|
Is this a similar configuration which is also present in the typespec definition file? @pulla2908, @muraus may we should also add the current value to the typespec definition file. Would love to help but never had made changes to the typespec definitions |
|
@DanielTheCoder I would say yes, this is the new approach: Maintain typespec definition file. CSV files are then generated based on this definition files (as far I understood). But I still have to deep in this topic a bit more. |
|
Unfortunately, I don't have any experience with TypeSpec files yet either - I am using the old CSV version of ebusd. Looks like the new approach is to maintan the TypeSpec Files and then the CDN Repository is automatically updated. @john30 It would be good to add a section about community contribution in the README or the wiki, describing how pull requests should look and what the process is. |
I think Its a good idea to open a new pull request. Where do you get communication protocol info from? like addresses, variable types, etc. Tried to use VCR700 setup for VCR720 but it doesnt work. |
|
New pull request is also my suggestion here. Then there start with type script definition changes. |
|
Maybe I can help here a bit, at least I can support or do a review, at the moment it is a matter of time for me :-( |
|
Much of the work has already been done/started for the VRC 720/x line of regulators. Please have a look at this PR: and this (most complete) Repo: https://github.com/jonesPD/ebusd-configuration/blob/master/ebusd-2.1.x/en/vaillant/15.ctlv2.csv The VRC700 is different in many registers, so this PR is really only for this older unit. |
|
Is the PR for typespec on humidity for vrc700 already existing? |
Added this in my pull request in tsp definition |

Added the support to read the actual room humidity provided by the internal sensor of the vrc700